Improve handling of p2pNetworkAndWalletReady #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The p2pNetworkAndWalletReady MonadicBinding might be removed from GC if its a local variable. I observed that in BisqSetup with a similar setup. It might be an implementation weakness in MonadicBinding (usage of weak references?). A tester reported that he does not see any result, which might be cause that the service never gets the onP2pNetworkAndWalletReady triggered if the MonadicBinding is not there anymore. By removing the listener we need at shutdown we need it anyway as class field (so codacy does not complain anymore). As well added a check if all is already complete to skip the MonadicBinding at all (not expected case in onAllServicesInitialized).
sqrrm
approved these changes
Sep 6, 2020
chimp1984
deleted the
improve-xmr-proof-p2pNetworkAndWalletReady-handling
branch
|
@ripcurlx Should be 1.3.8 not 1.3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The p2pNetworkAndWalletReady MonadicBinding might be removed from GC
if its a local variable. I observed that in BisqSetup with a similar
setup. It might be an implementation weakness in MonadicBinding
(usage of weak references?). A tester reported that he does not see any
result, which might be cause that the service never gets the
onP2pNetworkAndWalletReady triggered if the MonadicBinding is not there
anymore.
By removing the listener we need at shutdown we need it anyway as class
field (so codacy does not complain anymore). As well added a check if
all is already complete to skip the MonadicBinding at all
(not expected case in onAllServicesInitialized).