Refactor apitest for api calls to any daemon type #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change supports registering mediators and refund agents on daemons running on regest or testnet chains. Registering arbitrators is not supported.
Most test cases send requests to the alicedaemon, but new test cases will need to be able to send requests to arbitration and bob daemons.
This test case checks that mediators and refund agents can be registered over grpc, but not on mainnet.
sqrrm
approved these changes
Sep 16, 2020
| createRegisterDisputeAgentRequest("arbitrator"); | ||
| Throwable exception = assertThrows(StatusRuntimeException.class, () -> | ||
| grpcStubs(arbdaemon).disputeAgentsService.registerDisputeAgent(req)); | ||
| assertEquals("INVALID_ARGUMENT: arbitrators must be registered in a Bisq UI", |
There was a problem hiding this comment.
Relying on string matching for tests makes them fragile. At a minimum we should probably add a note for strings that are used in this way.
There was a problem hiding this comment.
I will fix this in another PR.
There was a problem hiding this comment.
Yeah, I think this happens quite a bit in other tests as well iirc. Not urgent, but good to have a better solution for the future.
There was a problem hiding this comment.
This string matching problem has bitten me a few times, when I misspelled "bitciond" in some test case setups.
PR 4540 fixes it.
This was referenced Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the test harness so test api calls can be made to any type of daemon (arbitrator, bob, alice), not just alice. A new
DisputeAgentRegistrationTestcase is included in these changes -- it needs to send requests to an arbitration daemon.This PR should be reviewed & merged after 4524.