Reduce initial data request #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a map with PersistableNetworkPayloads
… and reading logs from windows users makes it harder without line breaks.
…ture commit) Change API
This is intended to be able to merge the code base before bisq-network#4577 is merged. We can add the code base but not using the feature yet. Once we are ready for deployment we can revert this commit and have the feature activated.
ghubstan
reviewed
Oct 1, 2020
p2p/src/main/java/bisq/network/p2p/storage/persistence/StoreService.java
Outdated
Show resolved
Hide resolved
ghubstan
reviewed
Oct 1, 2020
ghubstan
reviewed
Oct 1, 2020
p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java
Show resolved
Hide resolved
ghubstan
reviewed
Oct 1, 2020
p2p/src/main/java/bisq/network/p2p/storage/persistence/PersistableNetworkPayloadStore.java
Show resolved
Hide resolved
|
I take back the comment about extra white space -- I see it is intended and why. utACK |
Merged
sqrrm
requested changes
Oct 2, 2020
p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java
Show resolved
Hide resolved
p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java
Show resolved
Hide resolved
p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java
Outdated
Show resolved
Hide resolved
p2p/src/main/java/bisq/network/p2p/storage/persistence/HistoricalDataStoreService.java
Outdated
Show resolved
Hide resolved
…as it was the version used in master as well. We cannot change that without breaking compatibility.
We do not expect a resource file without version number, so we could not deploy the updated trade stats resources if we use the new store. |
…calDataStoreService.java Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
…calDataStoreService.java Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
…calDataStoreService.java Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
Co-authored-by: sqrrm <sqrrm@users.noreply.github.com>
|
@sqrrm thanks for the review. Added some minor commit and applied your suggestions. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean version of #4519 which was based on #4233 from @freimair.
I decided to remove the git commit history and make new clean commits as it was too messy before and not easy to review.
Now the commits are clearly separated between pure refactoring, small not complex changes and the feature implementation.
It is basically only 2 commits which carry the main feature implementation. I hope that makes it easier to review and to get it merged.
In the last commit I deactivated the usage if the feature as we should deply it together with #4577 which is not ready yet and which will require some deployment planning and coordination. By reverting that last commit the feature gets activated.
By having the code base merged but not activated we avoid that the code base gets into problems with other large code change PRs which are pending but avoid any serious risk as it is a not executed code path.
Also we gain the benefit to have the version support deployed in case we decide to release the actiavted version in a later release.