-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tx broadcast to mempool explorer api #4943
Add tx broadcast to mempool explorer api #4943
Conversation
core/src/main/java/bisq/core/btc/wallet/http/MemPoolSpaceTxBroadcaster.java
Outdated
Show resolved
Hide resolved
300671a
to
f26e76c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
My main concern with this PR is that it reduces privacy in that the mempool operators get more information on bisq trades. I don't think this matters much as long as we have the very typical signature for bisq trades though.
Is it possible to not use this api if we are connected to our own nodes? |
Good point, there should be an option to disable this for privacy concerns, since it's just a backup broadcast feature anyway. |
Sure can be all added, just today EOD is code freeze for 1.5.2.... But to bring that into the right context: But the Bitcoin node operators are in the same position anyway (much worse if we would use the public network as bloomfilters are terribly broken privacy wise). So for those who do not run their own node there is not much of a change. But adding a simple option in the settings might be problematic as well as it requires some conext about the problem to make any informed decision. If users deactivate it and end up with failed trades it also impacts the trade peer (and cause lot of cost for Bisq from supports side). |
I agree if using the provided nodes, this really isn't a privacy issue. But can this be disabled if using my own nodes. |
PR is made: #4958 If local node is used the tx broadcast will not be done. I am not sure if that is perfect as it still carries the risk that a tx does not get broadcast (might be even a higher risk as there is only 1 node). To override that in the settings might be a solution but as said without context this might confuse more as it helps.... |
Send raw tx to mempool space explorer nodes.
Use https://mempool.space/api