Access concrete data stores #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2PService.getP2PDataStorage().getAppendOnlyDataStoreMap(). p2PService.getP2PDataStorage().getAppendOnlyDataStoreMap() iterates over all services including the historical data store service. It used the getMap method which should not be used at historical data store service as it is not clear if the live data or all data should be accessed.
HistoricalDataStoreService.getMap is called. HistoricalDataStoreService.getMap should not be used by domain clients but rather the custom methods getMapOfAllData, getMapOfLiveData or getMapSinceVersion. As we have not removed the calls from ProposalService and other domains we return getMapOfAllData() instead of the live map. This was prevented earlier for performance reasons. It is more safe thought to return in case of an illegal access all data instead of live data only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5030
Starts at commit 4489e57