Add new api methods 'getmyoffers' and 'getmyoffer' #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to 'getoffers' and 'getoffer', but filters out offers not created by the user. The new methods are so similar some offer list filtering and sorting was refactored in CoreOffersService. Also fixed some createoffer apitest cases in anticipation of a new OfferFilter, which will filter out offers not matching any user payment account.
Merged
Refering to PR bisq-network#5053. Test cases need to explicitly use a matching fiat payment account type when calling 'getoffers'.
|
force travis jar download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
getoffersandgetoffer, but filters out offers not created by the user. The new methods are so similar some offer list filtering and sorting was refactored inCoreOffersService.Also fixed some createoffer apitest cases in anticipation of a new
OfferFilter, which will filter out offers not matching any user payment account.