Fix stale trade statistics list view when new entries arrive #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the trade statistics list in TradesChartsView doesn't go stale upon new stats arrivals, by moving a fillList() call from the currency combobox onChangeConfirmed event handler to the selectedTradeStatistics (TradesChartsViewModel field) listener. Also avoid unnecessary use of an ObservableList as a temporary variable.
ripcurlx
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the trade statistics list in
TradesChartsViewdoesn't go stale upon new statistics arrivals, by moving afillList()call from the onChangeConfirmed currency combobox event handler to the listener of theselectedTradeStatisticsTradesChartsViewModelfield.(Also avoid unnecessary use of an
ObservableListas a temporary variable in thefillList()method.)--
I first spotted this bug a little while ago and it appears to have been present since early November 2020, at least looking through the commit history, so it most likely affects both master and the current v1.5.5 release candidate.