Message sign verify functionality compatible with Bitcoin core & electrum #5375
Conversation
There was a problem hiding this comment.
ACK
Sign
- Is Bisq compatible with Electrum?
Message signed by address in Electrum
Same message signed by Bisq with the same address resulted in the same signature.
Verify
- Can Bisq Verify A message signed by Electrum?
Message signed by electrum. Will Bisq be able to verify it?
Load signed message details from Electrum into Bisq. Will it verify?
Bisq verifies signature from Electrum successfully
Unhappy path
Modify message. Will Bisq be fooled?
Bisq successfully detects wrong signature due to modified message.
Tamper with address. Will bisq be able to tell?
Bisq successfully detects wrong signature due to wrong address.
Tamper with signature. Will bisq be able to tell?
Bisq successfully rejects wrong signature.
| messageSig.setText(""); | ||
| new Popup().information("Key not found in wallet").show(); | ||
| } else { | ||
| ECKey myPrivateKey = ECKey.fromPrivate(Utils.HEX.decode(privKeyHex)); |
There was a problem hiding this comment.
Tested by BitcoinJ.
| }); | ||
| buttonVerify.setOnAction(e -> { | ||
| try { | ||
| ECKey key = ECKey.signedMessageToKey(messageText.getText(), messageSig.getText()); |
There was a problem hiding this comment.
Tested by Bitcoinj.
ghost
mentioned this pull request
ghost
deleted the
Sign/verify functionality which is comparable to Electrum. Requested by @huey735
Screenshot: Bisq sign/verify & Electrum sign/verify.