Remove borders on separators in main nav Issue#5107

[andyheko]

Changed color of vertical border separator of main navigation to transparent on line#651 of bisq.css, so that the navigation would look cleaner and modern on both light mode and dark mode.

Resolves #5107

Light mode:

Dark mode:

[boring-cyborg]

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

[ripcurlx]

utACK - and congrats to your first successful PR! 👍

[ripcurlx]

But you missed to sign your commit.

[ripcurlx]

https://github.com/bisq-network/bisq-docs/blob/master/CONTRIBUTING.adoc#sign-commits-with-gpg

[ripcurlx]

@andyheko Did you see my comment regarding signing your commit? Otherwise the PR is fine 👍

[andyheko]

@ripcurlx I have set up a GPG key but still try to figure out how to sign my commit that's in this pull request

[andyheko]

sorry for the delay, but I couldn't find instruction for signing commit that's already pushed

[ripcurlx]

Hi @andyheko ! I would do following to get this PR in a mergeable state.

> git reset HEAD~2 (deletes your last two commits, but keeps your changes in place)

Delete the empty line you've added for testing and create a signed commit.

> git commit -S -m "Remove borders on separators in main nav #5107" -m "change color of border to transparent on line#651 of bisq.css"

As you changed history of your branch you have to force push now
> git push --force andyheko (or origin depending how you configured your remotes)

I hope that works for you.

[andyheko]

@ripcurlx Thanks so much for the help! I think this PR is in a mergeable state now.

[ripcurlx]

utACK

[boring-cyborg]

Awesome work, congrats on your first merged pull request!