Optimize DAO charts [7] #5795
Merged
Optimize DAO charts [7] #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimp1984
force-pushed
the
optimize-dao-charts-7
branch
from
3601c78 to
e1eed4e
Compare
|
I'll review starting with c7dd9a0 |
ripcurlx
previously approved these changes
Nov 9, 2021
avoid that slow operations in data model are running on UI thread
For initial rendering we need to delay a bit and wait until async calls are completed.
chimp1984
force-pushed
the
optimize-dao-charts-7
branch
from
e1eed4e to
8a4d1cb
Compare
|
Merged/Rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5794
Use CompleteableFuture and do chart calculations in threads. Reduce calls to calculations.