Improve fee handling #5826
Merged
Improve fee handling #5826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be used in follow-up commits)
Used in case of maker fee validation
Cleanup
in later commits)
Cleanups
That check is done if: - If we are after activation time - If filter is available - If value in filter is > 0 The check compares the paid fee and the fee value from filter and requires that paid fee is > 70% of filter value. See comments in code for more background.
chimp1984
force-pushed
the
improve-fee-handling
branch
from
5e940a5 to
b00d317
Compare
ripcurlx
reviewed
Nov 15, 2021
ripcurlx
approved these changes
Nov 16, 2021
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.