Fix broken test for new build #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for Gradle Verification fix before I can rebase this test fix on master. |
ripcurlx
force-pushed
the
fix-broken-test
branch
from
660914c to
4341114
Compare
ripcurlx
force-pushed
the
fix-broken-test
branch
from
4341114 to
c64e6f3
Compare
bisq-github-admin-3
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the new build process exposed a timing issue in the setting of the locale that wasn't existing before.
This PR sets the locale additionally in the GlobalSettings.
This bug only surfaces for non-english setups.