Add support/help links on the UI #5985

ghost · 2022-01-20T14:50:20Z

Fixes #5972

Screenshots:

ripcurlx · 2022-01-27T16:01:37Z

@xyzmaker123 Could you please adapt the links to point to matrix instead? See #5972 (comment)

ghost · 2022-01-28T09:13:00Z

@ripcurlx Done

ripcurlx

ACK - Tested it on Regtest

I did make some changes in the UI to make the question icon less prominent and improve readability of the informational text to make it not too hard to read.

I'm still waiting for @m52go to review the text with the here link I'm not too much a fan of as you don't know what to expect when clicking on here.

desktop/src/main/java/bisq/desktop/theme-dark.css

desktop/src/main/java/bisq/desktop/components/TitledGroupBg.java

ripcurlx · 2022-02-01T12:33:57Z

core/src/main/resources/i18n/displayStrings.properties

+portfolio.pending.support.text.getHelp=Take a look at the trade process \
+  [here](https://docs.bisq.network/getting-started.html#4-send-payment)\
+  \n\nIf you have any problems you can try to contact the trade peer in the trade chat.


@m52go Could you please review this paragraph? Thanks!

ripcurlx · 2022-02-01T12:52:08Z

🤔 After reading through #5972 I'm having second thoughts on my changes above. Maybe we shouldn't use opacity in that case to make it a little bit more different to the help overlays in the columns.

ripcurlx · 2022-02-01T12:54:01Z

Maybe we should also add the link icon to the text links we use everywhere for text that links to an external website.

m52go

Primary aims of my suggested changes:

Re-order text blocks to (1) encourage trader chat, (2) seek help on Matrix, and (3) read docs
Replace docs link with wiki links
Link to trade rules and dispute resolution instead of instructions on how to make a payment

m52go · 2022-02-01T17:19:46Z

core/src/main/resources/i18n/displayStrings.properties

+portfolio.pending.support.text.getHelp=Take a look at the trade process \
+  [here](https://docs.bisq.network/getting-started.html#4-send-payment)\
+  \n\nIf you have any problems you can try to contact the trade peer in the trade chat.


Suggested change

portfolio.pending.support.text.getHelp=Take a look at the trade process \

[here](https://docs.bisq.network/getting-started.html#4-send-payment)\

\n\nIf you have any problems you can try to contact the trade peer in the trade chat.

portfolio.pending.support.text.getHelp=Many issues can be resolved by simply chatting with your trading peer.

It would be great if there was an empty line under the "Need help?" heading.

m52go · 2022-02-01T17:20:00Z

core/src/main/resources/i18n/displayStrings.properties

+portfolio.pending.stillNotResolved=If your issue still is not resolved ask the Bisq community or request support \
+  from a mediator using the link below: \n[https://bisq.chat](https://bisq.chat)


Suggested change

portfolio.pending.stillNotResolved=If your issue still is not resolved ask the Bisq community or request support \

from a mediator using the link below: \n[https://bisq.chat](https://bisq.chat)

portfolio.pending.stillNotResolved=If your issue remains unsolved, you can request \

support from support agents, mediators, and the Bisq community in our \

[Matrix chatroom](https://bisq.chat). \

\n\nFor reference, make sure to check \

out Bisq's [trading rules](https://bisq.wiki/Trading_rules) and \

[dispute resolution](https://bisq.wiki/Dispute_resolution).

ghost · 2022-02-02T08:00:29Z

desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java

@@ -108,7 +108,6 @@ private void buildViews() {
        SimpleMarkdownLabel label = addSimpleMarkdownLabel(leftGridPane, ++leftGridPaneRowIndex);
        AutoTooltipButton button = (AutoTooltipButton) addButtonAfterGroup(leftGridPane, ++leftGridPaneRowIndex, "");
        SimpleMarkdownLabel footerLabel = addSimpleMarkdownLabel(leftGridPane, ++leftGridPaneRowIndex, Res.get("portfolio.pending.stillNotResolved"), 10);
-        footerLabel.getStyleClass().add("small-text");


I'm afraid there is not enough space for making this text bigger. This change cause that there is no space between Need help? heading and paragraph (#5985 (comment))

I think using converted 11px instead of 10px is fine for the sub text IMO.

But it is still not enough for all use cases as you can see in the screenshots. So I'd just increase the SubView min height in that case.

ghost · 2022-02-04T08:28:47Z

@ripcurlx I see a few conversations are open on this pull request. Let me know if you'd like something from me regarding them.

m52go

Sorry I usually test changes like this but my local environment was broken until just now.

Disregard my last review...suggestions in this new review should look like this. I don't see a use for the getHelp string.

core/src/main/resources/i18n/displayStrings.properties

ripcurlx · 2022-02-07T09:18:03Z

@ripcurlx I see a few conversations are open on this pull request. Let me know if you'd like something from me regarding them.

Could you please apply the last remarks from @m52go ? Thanks! I'll review it afterwards again and have a look at the ? icon if I find something that is consistent with our remaining UI, but still different enough to the ? roll over info in the columns.

Thanks!

ghost · 2022-02-07T12:42:12Z

@m52go What about other states? They doesn't looks good at the moment, f.e.:

Co-authored-by: m52go <735155+m52go@users.noreply.github.com>

ripcurlx · 2022-02-09T08:56:03Z

@m52go What about other states? They doesn't looks good at the moment, f.e.:

I'll have a look if we could slightly reduce the font size for the sub-text (something between regular and small-text) so we gain more space, but still can read it. I'll have a look at this PR today.

ripcurlx · 2022-02-09T10:17:25Z

Ok - I did some clean ups and adaptions to fix the text issue in pending trades and use the action color and a different icon for help links

ripcurlx

ACK

ghost · 2022-02-19T17:43:19Z

Bug: text formatting under Check Payment

Also, that odd formatted line hyperlinks to e.g. bank that does not make sense:

pazza83 · 2022-03-12T23:06:38Z

Tested this and it works well

ghost marked this pull request as ready for review January 27, 2022 15:27

ripcurlx previously approved these changes Feb 1, 2022

View reviewed changes

ripcurlx added this to the v1.8.3 milestone Feb 1, 2022

m52go reviewed Feb 1, 2022

View reviewed changes

ghost commented Feb 2, 2022

View reviewed changes

m52go reviewed Feb 4, 2022

View reviewed changes

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved

core/src/main/resources/i18n/displayStrings.properties Outdated Show resolved Hide resolved

ghost dismissed ripcurlx’s stale review via 402d704 February 7, 2022 12:24

xyzmaker123 and others added 8 commits February 8, 2022 09:44

Introduce SimpleMarkdownLabel

90c2bfa

Add support/help links on the UI - trade details

19d6b26

Add support/help links on the UI - question mark links

feb6af1

Adapt help icon creation and style

77152cc

Improve markdown styling

2d2df30

Improve readability

d2760fd

Update "still not resolved" message

469f589

Co-authored-by: m52go <735155+m52go@users.noreply.github.com>

Update "get help" message

9831d19

Co-authored-by: m52go <735155+m52go@users.noreply.github.com>

ripcurlx added 5 commits February 9, 2022 10:51

Improve layout for pending trades

0017ccb

Not keep empty translation key

4e22573

Use bisq.wiki links as suggested by @m52go

4e0eff8

Rename help url setter

8cc9a12

Use action color as it is used with other action icons

bc1a09f

ripcurlx approved these changes Feb 9, 2022

View reviewed changes

ripcurlx merged commit 15abe71 into bisq-network:master Feb 9, 2022

ghost mentioned this pull request Feb 15, 2022

For cycle 33 bisq-network/compensation#998

Closed

ghost mentioned this pull request Feb 20, 2022

Fix bug with text rendering on trade step info #6064

Merged

ripcurlx mentioned this pull request Feb 23, 2022

For Cycle 33 bisq-network/compensation#1016

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support/help links on the UI #5985

Add support/help links on the UI #5985

ghost commented Jan 20, 2022 •

edited by ghost

Loading

ripcurlx commented Jan 27, 2022

ghost commented Jan 28, 2022

ripcurlx left a comment

ripcurlx Feb 1, 2022

ripcurlx commented Feb 1, 2022 •

edited

Loading

ripcurlx commented Feb 1, 2022

m52go left a comment •

edited

Loading

m52go Feb 1, 2022

m52go Feb 1, 2022 •

edited

Loading

ghost Feb 2, 2022

ripcurlx Feb 9, 2022

ghost commented Feb 4, 2022

m52go left a comment •

edited

Loading

ripcurlx commented Feb 7, 2022

ghost commented Feb 7, 2022

ripcurlx commented Feb 9, 2022

ripcurlx commented Feb 9, 2022

ripcurlx left a comment

ghost commented Feb 19, 2022 •

edited by ghost

Loading

pazza83 commented Mar 12, 2022

		portfolio.pending.stillNotResolved=If your issue still is not resolved ask the Bisq community or request support \
		from a mediator using the link below: \n[https://bisq.chat](https://bisq.chat)

-portfolio.pending.stillNotResolved=If your issue still is not resolved ask the Bisq community or request support \
-  from a mediator using the link below: \n[https://bisq.chat](https://bisq.chat)
+portfolio.pending.stillNotResolved=If your issue remains unsolved, you can request \
+  support from support agents, mediators, and the Bisq community in our \
+  [Matrix chatroom](https://bisq.chat). \
+  \n\nFor reference, make sure to check \
+  out Bisq's [trading rules](https://bisq.wiki/Trading_rules) and \
+  [dispute resolution](https://bisq.wiki/Dispute_resolution).

Add support/help links on the UI #5985

Add support/help links on the UI #5985

Conversation

ghost commented Jan 20, 2022 • edited by ghost Loading

Screenshots:

ripcurlx commented Jan 27, 2022

ghost commented Jan 28, 2022

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx Feb 1, 2022

Choose a reason for hiding this comment

ripcurlx commented Feb 1, 2022 • edited Loading

ripcurlx commented Feb 1, 2022

m52go left a comment • edited Loading

Choose a reason for hiding this comment

m52go Feb 1, 2022

Choose a reason for hiding this comment

m52go Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

ghost Feb 2, 2022

Choose a reason for hiding this comment

ripcurlx Feb 9, 2022

Choose a reason for hiding this comment

ghost commented Feb 4, 2022

m52go left a comment • edited Loading

Choose a reason for hiding this comment

ripcurlx commented Feb 7, 2022

ghost commented Feb 7, 2022

ripcurlx commented Feb 9, 2022

ripcurlx commented Feb 9, 2022

ripcurlx left a comment

Choose a reason for hiding this comment

ghost commented Feb 19, 2022 • edited by ghost Loading

pazza83 commented Mar 12, 2022

ghost commented Jan 20, 2022 •

edited by ghost

Loading

ripcurlx commented Feb 1, 2022 •

edited

Loading

m52go left a comment •

edited

Loading

m52go Feb 1, 2022 •

edited

Loading

m52go left a comment •

edited

Loading

ghost commented Feb 19, 2022 •

edited by ghost

Loading