Cleanup: remove unused classes #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
suggested changes
Jan 24, 2022
ghost
requested a review
from 
|
Fixed |
ripcurlx
suggested changes
Jan 25, 2022
|
Fixed |
ripcurlx
approved these changes
Jan 25, 2022
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During code exploration I sometimes saw info in intellij idea that certain class is never used. I've tried to run inspection to find all of places like that but it didn't worked properly - issue is already reported in jetbrains youtrack.
2 classes in this pr I've found manually, 3 others were found by inspection. Probably there is more cases like that in application.
Maybe this pull request will be a starting point to the discussion on a more sophisticated static code analysis solution for bisq.