Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting on bonded roles view #6002

Merged
merged 1 commit into from Feb 1, 2022
Merged

Fix sorting on bonded roles view #6002

merged 1 commit into from Feb 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2022

Fixes #6000

alkum
alkum approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@alkum alkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested and looks good, sorting works on all columns.

As a side note: would have been easier to review if it was split over multiple commits instead of one big one.

ripcurlx
ripcurlx approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Code changes are looking fine 👍

@ripcurlx ripcurlx merged commit 7a32d4c into bisq-network:master Feb 1, 2022
@ripcurlx ripcurlx added this to the v1.8.3 milestone Feb 1, 2022
@ghost ghost mentioned this pull request Feb 15, 2022
Closed
@alkum alkum mentioned this pull request Feb 17, 2022
Closed
@ripcurlx ripcurlx mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.3
Development

Successfully merging this pull request may close these issues.

DAO > Bonding > Bonded roles, ordering by column not working
2 participants
@ripcurlx @alkum