Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign/Verify message for DAO bonded roles #6032

Merged
merged 1 commit into from Feb 15, 2022
Merged

Sign/Verify message for DAO bonded roles #6032

merged 1 commit into from Feb 15, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2022

Adds the ability to sign and verify a message for DAO bonded roles. Required for bisq-network/bisq2#68
Reuses the same code for sign/verify DAO proof of burn txs.

image

image

image

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Small nits...

@ghost ghost marked this pull request as ready for review February 11, 2022 03:58
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.3 milestone Feb 15, 2022
@ripcurlx ripcurlx merged commit d671b68 into bisq-network:master Feb 15, 2022
@ghost ghost mentioned this pull request Feb 21, 2022
@ghost ghost deleted the sign_verify_msg_dao branch October 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants