Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show buyer/seller in terms of BTC #6049

Merged
merged 1 commit into from Feb 17, 2022
Merged

Show buyer/seller in terms of BTC #6049

merged 1 commit into from Feb 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2022

Fixes #6046

e.g.
Instead of "Maker as XMR buyer / Taker as XMR seller"
shows "Maker as BTC seller / Taker as BTC buyer"

Affects Dispute details screen and Offer details screen (same code is used for both).


Examples:

Dispute detail:

image

Offer detail:

image

image

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.3 milestone Feb 17, 2022
@ripcurlx ripcurlx merged commit 70d9188 into bisq-network:master Feb 17, 2022
@ghost ghost mentioned this pull request Feb 21, 2022
@pazza83
Copy link

pazza83 commented Mar 12, 2022

Hi @jmacxx I am still seeing the old text with 1.8.4?

xmr seller

@ghost ghost deleted the fix_issue_6046 branch October 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'Dispute Details' window to always show buyer/ seller in terms of BTC
2 participants