Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger price truncation of prompt text #6111

Merged
merged 1 commit into from Mar 21, 2022
Merged

Trigger price truncation of prompt text #6111

merged 1 commit into from Mar 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2022

Fixes #5189

@alkum
Copy link
Contributor

alkum commented Mar 18, 2022

ACK

@alkum alkum mentioned this pull request Mar 18, 2022
Closed
ripcurlx
ripcurlx approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it on Regtest and it works so far. Of course the perfect solution would have been to only truncate if it exceeds the input field, but that it is a little more complicated to achieve in that case and I think it is sufficient so far as is.

@ripcurlx ripcurlx added this to the v1.8.5 milestone Mar 21, 2022
@ripcurlx ripcurlx merged commit 5236353 into bisq-network:master Mar 21, 2022
@ghost ghost mentioned this pull request Mar 25, 2022
Closed
@ripcurlx ripcurlx mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

Trigger price truncation of prompt text not working
2 participants
@alkum @ripcurlx