Create API cli and daemon releases as zip archives #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each distribution contains a runnable jar with a MANIFEST.MF defining the classpath (all jar files in lib/). To run daemon.jar: $ java -jar daemon.jar --apiPassword=xyz To run cli.jar: $ java -jar cli.jar --password=xyz <cmd> TODO Sign jar files, generate checksums.
ripcurlx
previously approved these changes
Mar 30, 2022
ghubstan
changed the title
ripcurlx
approved these changes
Apr 3, 2022
|
Are we gonna update downloads page with info about daemon/cli, or put some instructions about running daemon/cli without need to build it from sources? Just wanted to answer here with some link. |
I think we should add some information to the downloads page and the GitHub release notes. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bisq gradle build already creates distribution .tar files within the cli and daemon subprojects'
build/distributionsdirectories. Instead of using additional gradle tasks to create runnablecli.jaranddaemon.jarfiles, simple bash scripts arrange the .tar contents into .zip files containing runnable jars at the root level, and dependent jars in theirlibdirectories.The cli release zip file structure looks like this:
$ tree . . ├── [me 165543] cli.jar └── [me 4096] lib ├── [me 3120] annotations-4.1.1.4.jar ├── [me 230905] checker-qual-3.8.0.jar ├── [me 15994] error_prone_annotations-2.9.0.jar ├── [me 4617] failureaccess-1.0.1.jar ├── [me 254575] grpc-api-1.42.1.jar ├── [me 30595] grpc-context-1.42.1.jar ├── [me 686612] grpc-core-1.42.1.jar ├── [me 8185495] grpc-netty-shaded-1.42.1.jar ├── [me 5118] grpc-protobuf-1.42.1.jar ├── [me 7570] grpc-protobuf-lite-1.42.1.jar ├── [me 50385] grpc-stub-1.42.1.jar ├── [me 240255] gson-2.8.6.jar ├── [me 2874025] guava-30.1.1-jre.jar ├── [me 8781] j2objc-annotations-1.3.jar ├── [me 78146] jopt-simple-5.0.4.jar ├── [me 19936] jsr305-3.0.2.jar ├── [me 2199] listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar ├── [me 309130] logback-classic-1.1.11.jar ├── [me 475477] logback-core-1.1.11.jar ├── [me 6385] perfmark-api-0.23.0.jar ├── [me 1681558] protobuf-java-3.19.1.jar ├── [me 1557780] proto-google-common-protos-2.0.1.jar ├── [me 4715421] proto.jar └── [me 41472] slf4j-api-1.7.30.jarTo call getversion from cli.jar:
$ java -jar cli.jar --password=becareful getversionThe daemon release tree structure would look the same (but more jars in the lib dir).
To run daemon.jar on mainnet:
$ java -jar daemon.jar --apiPassword=becarefulTODO Sign release .zip files, add checksums, etc...
Based on
master.