Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pause between fee requests #6133

Merged
merged 1 commit into from Apr 21, 2022
Merged

Fix pause between fee requests #6133

merged 1 commit into from Apr 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2022

requestFees method contained logic that prevents too frequent requests. Unfortunately actual code execution was not stopped.

ripcurlx
ripcurlx approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - True it seems to be missing this return statement. NIT: the initialization of the variable is not necessary IMO as it is 0 anyways.

@ripcurlx ripcurlx added this to the v1.9.0 milestone Apr 21, 2022
@ripcurlx ripcurlx merged commit dde4199 into bisq-network:master Apr 21, 2022
@ripcurlx ripcurlx mentioned this pull request Apr 26, 2022
Closed
@ghost ghost mentioned this pull request May 11, 2022
Closed
@ripcurlx ripcurlx mentioned this pull request Jun 1, 2022
Closed
@ghost ghost mentioned this pull request Jun 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ripcurlx