Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popup reminder to inform users of trading rules #6164

Merged
merged 1 commit into from Apr 28, 2022
Merged

Add popup reminder to inform users of trading rules #6164

merged 1 commit into from Apr 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2022

Requested by the support team.
There has been an uptick of users including bitcoin txids in payment reference fields.

Once app has started, shows popup:

image

@w0000000t @pazza83 @leo816 @MwithM 👀

@w0000000t
Copy link
Contributor

w0000000t commented Apr 26, 2022

Cool!
Myself, I would tweak it to make shorter and more straight to the point, so lazy users won't just skip it with "eh don't want to read it all, let's just click the green button and be done with it".

KNOW THE PENALTIES TO AVOID THE PENALTIES

Not following the trading rules [1] could make you lose money!
Make sure to check what the penalties [2] are, and have a chat with the support team [3] in case of doubts.

I would place the ALL CAPS warning directly in the green text title, for maximum impact and least text possible

@ghost
Copy link
Author

ghost commented Apr 26, 2022

@w0000000t I tried putting your all caps message in the title but there were a couple of reasons why it did not look good:

(a) it got truncated, and
(b) it seems way too harsh to be shouting in the popup title like that, at application startup.

So I prefer the all caps message in the text body, as shown in the OP. ☝️

example, for reference

image

@ghost ghost marked this pull request as ready for review April 27, 2022 16:44
@ghost
Copy link
Author

ghost commented Apr 27, 2022

@ripcurlx any chance this can go in the coming release, v1.9.0?

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Code changes are looking fine 👍

@ripcurlx ripcurlx added this to the v1.9.0 milestone Apr 28, 2022
@ripcurlx ripcurlx merged commit b71ffc2 into bisq-network:master Apr 28, 2022
@ghost ghost mentioned this pull request May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants