Check current fee receiver list whenever a fee tx is validated. #6182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue in support: the current BTC fee receiver address was not recognized when checking a taker fee payment.
This caused mediation to start, analysis of logs showed that the first seednode did not provide any filter objects, and so caused the validator to be initialized without the fee address which comes from the filter. (The data downloaded from the second seednode did contain 2 filter objects, but by that time initialization had already passed).
This change addresses the issue by obtaining the fee addresses each time a fee payment is validated, instead of a snapshot upon service initialization. There's no overhead since the fee addresses are already stored in memory, and the benefit is that whenever a new filter is received, its contents are used.