Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check current fee receiver list whenever a fee tx is validated. #6182

Merged
merged 1 commit into from May 2, 2022
Merged

Check current fee receiver list whenever a fee tx is validated. #6182

merged 1 commit into from May 2, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2022

Had an issue in support: the current BTC fee receiver address was not recognized when checking a taker fee payment.

This caused mediation to start, analysis of logs showed that the first seednode did not provide any filter objects, and so caused the validator to be initialized without the fee address which comes from the filter. (The data downloaded from the second seednode did contain 2 filter objects, but by that time initialization had already passed).

This change addresses the issue by obtaining the fee addresses each time a fee payment is validated, instead of a snapshot upon service initialization. There's no overhead since the fee addresses are already stored in memory, and the benefit is that whenever a new filter is received, its contents are used.

@ripcurlx ripcurlx modified the milestones: v1.9.0, v1.9.1 May 1, 2022
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 80aff38 into bisq-network:master May 2, 2022
@ghost ghost mentioned this pull request May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant