Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart series for total trade fees #6204

Merged
merged 4 commits into from
May 16, 2022
Merged

Add chart series for total trade fees #6204

merged 4 commits into from
May 16, 2022

Conversation

chimp1984
Copy link
Contributor

Implements #6203

@chimp1984 chimp1984 marked this pull request as ready for review May 15, 2022 15:35
@chimp1984
Copy link
Contributor Author

@xyzmaker123 @jmacxx Anyone time for a review?

@ghost
Copy link

ghost commented May 16, 2022

@chimp1984 Sure, I'm gonna review it within 30-60 minutes.

ghost
ghost approved these changes May 16, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

  • tested if chart works in a few edge case scenarios
  • roughly reviewed code changes
  • I didn't fully analysed data validity

NOTE: Codacy fails

@ripcurlx
Copy link
Contributor

ACK

  • tested if chart works in a few edge case scenarios
  • roughly reviewed code changes
  • I didn't fully analysed data validity

NOTE: Codacy fails

Ignored this specific remark, as the whole file doesn't apply it ATM.

@ripcurlx ripcurlx closed this May 16, 2022
@ripcurlx ripcurlx reopened this May 16, 2022
@bisq-github-admin-3
Copy link
Contributor

Merging as Codacy is not accepting the exclusion of a rule.

@bisq-github-admin-3 bisq-github-admin-3 merged commit 6fa87ae into bisq-network:master May 16, 2022
@bisq-github-admin-3 bisq-github-admin-3 added this to the v1.9.2 milestone May 16, 2022
@chimp1984 chimp1984 deleted the add-revenue-chart branch May 20, 2022 20:26
@ripcurlx ripcurlx mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @ripcurlx @bisq-github-admin-3