Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bisq2 rest infrastructure for daonode #6228

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Use bisq2 rest infrastructure for daonode #6228

merged 6 commits into from
Jun 20, 2022

Conversation

chimp1984
Copy link
Contributor

No description provided.

@chimp1984 chimp1984 marked this pull request as ready for review May 30, 2022 09:49
@chimp1984
Copy link
Contributor Author

@ghubstan Could you review?

1 similar comment
@chimp1984
Copy link
Contributor Author

@ghubstan Could you review?

@ghubstan
Copy link
Contributor

ghubstan commented Jun 6, 2022

I've done one pass (review) through all the classes in the bisq.daonode package. Swagger works -- nice!

@chimp1984
Copy link
Contributor Author

@ghubstan Thanks for the review!

@ripcurlx ripcurlx added this to the v1.9.2 milestone Jun 9, 2022
ripcurlx
ripcurlx approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #6228 (comment)

ripcurlx
ripcurlx suggested changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - I just recognized that with this PR also the verification of new dependencies failed, but didn't result the build to fail.
Please also update the verification-metadata.xml by running ./gradlew --write-verification-metadata sha25 and verify the hashes generated.

@ripcurlx
Copy link
Contributor

@chimp1984 Could you please resolve the conflicts by rebasing to master and re-running the verification-metadata generation? Thanks!

@chimp1984 chimp1984 force-pushed the use-bisq2-rest-infrastructure-for-daonode branch from 66e6654 to bbf7987 Compare June 14, 2022 11:06
@chimp1984
Copy link
Contributor Author

@chimp1984 Could you please resolve the conflicts by rebasing to master and re-running the verification-metadata generation? Thanks!

Done.

@ripcurlx ripcurlx merged commit b794312 into bisq-network:master Jun 20, 2022
@chimp1984 chimp1984 mentioned this pull request Jun 29, 2022
Closed
@chimp1984 chimp1984 deleted the use-bisq2-rest-infrastructure-for-daonode branch October 20, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubstan ghubstan ghubstan left review comments

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.3
Development

Successfully merging this pull request may close these issues.
3 participants
@chimp1984 @ghubstan @ripcurlx