Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve broadcast handler #6500

Merged
merged 11 commits into from
Jan 6, 2023
Merged

Improve broadcast handler #6500

merged 11 commits into from
Jan 6, 2023

Conversation

HenrikJannsen
Copy link
Collaborator

No description provided.

@HenrikJannsen
Use AtomicBoolean for stopped and timeoutTriggered
41fb5e4 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Do not send close message to banned node
20b39a4 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Remove stop setter at cancel
de32339 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Increase numOfFailedBroadcasts at timeout
3e48956 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Maintain pending futures and cancel them at cleanup.
5e29bfe 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen HenrikJannsen force-pushed the improve_broadcast_handler branch from 52c6fee to 5e29bfe Compare January 4, 2023 19:02
@HenrikJannsen
Check if setException returns false and if so, cancel future.
5efd13a 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Improve log
1172eec 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Combine nested if statements
819c6fb 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
HenrikJannsen added a commit to HenrikJannsen/bisq that referenced this pull request Jan 5, 2023
@HenrikJannsen
merge bisq-network#6500
7457b0b 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Increase pool size
7196023 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Cleanup
8b0f8fb 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Cleanup
9fe3d22 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen HenrikJannsen mentioned this pull request Jan 6, 2023
Closed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.9 milestone Jan 6, 2023
alejandrogarcia83
alejandrogarcia83 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit ec411a4 into bisq-network:master Jan 6, 2023
@HenrikJannsen HenrikJannsen deleted the improve_broadcast_handler branch January 6, 2023 16:05
@HenrikJannsen HenrikJannsen mentioned this pull request Jan 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.9
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikJannsen @alejandrogarcia83