Warn user when free disk space is too low.

[ghost]

If there is insufficient free disk space to persist settings, user's database can be corrupted.
Check periodically for adequate free disk space, and show a warning message if necessary.

[alejandrogarcia83]

Hi @yonson2023!
Thank you for implementing this. Code wise it looks good!

1. If we're low on disk space it doesn't make any sense continue running. However, we cannot shut down Bisq without showing that popup and pausing all operations is non-trivial. So what do you think about replacing the close button with a shutdown button?
   You could call:

new Popup().warning(msg).
    .useShutDownButton()
    .hideCloseButton()
    .show()

2. We had a bug in the past where a new "DAO is out of sync" popup kept popping up and the user was not able to click the "resync" button. Some users create offers and leave Bisq open for an extended period of time. Here we are opening a new popup every time a new block gets created (if we're low on disk space). I would suggest to check whether a popup is already present.

[ghost]

1. replacing the close button with a shutdown button

Shutting down when disk space is exhausted is what causes corruption of Bisq's DB files. What the user needs to do is free up some disk space urgently in this case.

I applied your other suggestions, thanks!

[alejandrogarcia83]

Shutting down when disk space is exhausted is what causes corruption of Bisq's DB files. What the user needs to do is free up some disk space urgently in this case.

I agree with you. Nothing we can really do because it's most likely too late for long-running instances.

ACK. Tested on regtest.

The popup check is not optimal because another popup (dao out of sync, trade notification, ...) could be present already, but it is a rare case.