Speed up loading and scrolling of trade history #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce a bottleneck in the closed-trades-view load & table scrolling, caused by a call to 'ClosedTradesManager.getNumPastTrades' for each list item displayed. This repeatedly scans the entire collection of closed trades and BSQ swap trades, in order to count all those which share a given peer node address. (Scanning the BSQ swap trades is particularly slow due to their filtering by tx confirmation status.) To this end, cache the counts of trades by peer node address with a nullable Multiset field in ClosedTradesManager & BsqSwapTradeManager, so that the trades are scanned at most once when the view loads. Add listeners to clear the respective cache when the trade list changes or the BSQ wallet txs change.
The return value is a (cached) SetMultimap, not a multiset.
Add a third cache to WalletService, cleared upon wallet change events, which maps txIds to txs. This allows the speedup of repeated calls to 'WalletService.getConfidenceForTxId', by avoiding the need to copy and scan the entire set of wallet txs to find the one with matching id, for each method invocation. This is mainly to provide a further speedup to the closed-trades-view load, by making it much faster to filter the list of BSQ swap trades by tx confirmation status in 'ClosedTradesDataModel.applyList' and 'ClosedTradesManager.getNumPastTrades'.
|
Hey @stejbac , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a quadratic time bug while filtering the list of BSQ swap trades for their tx confirmation status, as needed by
ClosedTradesView. It also fixes a (sort-of) cubic time bug caused by the repeated invocation ofClosedTradableManager.getNumPastTrades(once for each list item). It does this by caching the peer node address counts over all the closed trades & confirmed BSQ swaps, as well as caching a mapping of txIds to txs inWalletServiceto avoid repeated copying and scanning of the wallet tx list while checking for confirmation status by txId.These issues were making the closed trades view load extremely slow on my Bisq instance (taking more than 20s), which has around 1300 past trades, a bit under half of which are BSQ swaps. It was also making scrolling and paging almost unusable. The following is a screenshot of the hotspots from JProfiler, prior to the changes:
