Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UI improvements #6597

Merged
merged 1 commit into from Mar 27, 2023
Merged

Support UI improvements #6597

merged 1 commit into from Mar 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2023 •
edited by ghost
Loading

From RA:

Don't close mediation tickets just after submitting mediation suggestion. Ideas: Close them 72h after suggestion, let the trader close it after suggestion is submitted, or even software checks if deposit tx has been spent. If the solution implemented generates noise, let mediators close it for good.

bisq-network/projects#67

Changes:

  • Mediation tickets to remain open after mediator sends proposal to traders. New state: RESULT_PROPOSED.
  • Close trader's support ticket when trade pays out (previously it was closed by mediator proposal).
  • Status update to mediator when traders press accept/reject mediation, trade pays out, or arbitration started.
  • Refine/clarify messages at mediation and arbitration (text was provided by @refund-agent2). [SEE SCREENSHOTS]
  • Mediator can copy their mediation chat session in order to send to refund agent.
  • Mediator decides when to close a ticket and can reopen at will.
  • CLOSE TICKET | RE-OPEN button on mediation tab can be used by mediator and trader.
  • Fix a bug where option trade system message was displayed to a trade peer.
  • Include explanation on how much buyer and seller get from mediation.
  • 3 buttons: accept, reject, and send to arbitration.
  • Modify "next steps text".

Mediation proposal text change:

(includes RA review change)
image

Arbitration help text change:

(includes RA review change)
image

Mediator chat can be copied

image

Trader 1 accepts mediation proposal.
image

Trader 2 rejects mediation proposal. Mediator knows to contact them and discuss.
image

Trade pays out:
image

Or trader starts arbitration after timelock expires:
image

Close | Re-Open button:

image

image

image

refund-agent2
refund-agent2 reviewed Mar 7, 2023
View reviewed changes
core/src/main/resources/i18n/displayStrings.properties Outdated
@@ -1274,6 +1275,19 @@ support.initialInfo=Please enter a description of your problem in the text field
\t● You need to cooperate with the {2} and provide the information they request to make your case.\n\
\t● You accepted the rules outlined in the dispute document in the user agreement when you first started the application.\n\n\
You can read more about the dispute process at: {3}
support.initialInfoRefundAgent=Please enter a description of why you opened arbitration. Add as much information as possible to speed up dispute resolution time. Mediation and trading chats are not shared with the arbitrator.\n\n\
Copy link

@refund-agent2 refund-agent2 Mar 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=Please describe why have you opened arbitration, or why do you think your peer did so.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made, screenshot updated above in OP.

refund-agent2
refund-agent2 reviewed Mar 7, 2023
View reviewed changes
core/src/main/resources/i18n/displayStrings.properties Outdated
@@ -2877,7 +2891,10 @@ disputeSummaryWindow.close.msg=Ticket closed on {0}\n\
disputeSummaryWindow.close.msgWithSig={0}{1}{2}{3}

disputeSummaryWindow.close.nextStepsForMediation=\nNext steps:\n\
Open trade and accept or reject suggestion from mediator
Open trade to accept suggestion from mediator. If you don't agree with it, reopen the ticket and explain your motives. \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open trade to accept suggestion from mediator, or click Reject Proposal If you don't agree with it. Explain why do you disagree at the mediation ticket.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made, screenshot updated above in OP.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New suggestion for "Next steps" field:

Go to Open trades to accept the suggestion from mediator, or click Reject Proposal if you disagree. Explain your reasons at the mediation ticket.
If the trade has not concluded in the next 48h after accepting mediation proposal, inform your mediator on this chat.
Keep in mind that if arbitration is opened by any party, it will cost 1 security deposit. The full amount can't be reimbursed for security reasons.

@ghost ghost requested a review from refund-agent2 March 7, 2023 13:59
refund-agent2
refund-agent2 approved these changes Mar 7, 2023
View reviewed changes
Copy link

@refund-agent2 refund-agent2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, text is as suggested.

refund-agent2
refund-agent2 previously approved these changes Mar 7, 2023
View reviewed changes
Copy link

@refund-agent2 refund-agent2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, text only.

@refund-agent2 refund-agent2 mentioned this pull request Mar 8, 2023
Open
4 tasks
@pazza83
Copy link

pazza83 commented Mar 9, 2023

Here is my suggestion for the next steps text:

  1. Please accept or reject the mediation proposal (if you choose to reject please explain your reasons on the mediation ticket).
  2. If both traders accept the mediation proposal the trade will pay out. If the trade has not paid 48 hours after you have accepted the mediation proposal please inform your mediator on this ticket.
  3. If both traders do not accept the mediation proposal either trader can open arbitration after 20 days for fiat trades or 10 days for altcoin trades. Keep in mind that the arbitrator can only make the payout of the trade amount + 1 security deposit. The other security deposit will be left unpaid).

@ghost
Copy link
Author

ghost commented Mar 11, 2023

@pazza83 @refund-agent2 For the next steps text, there are two suggestions.. Which should I use for the PR?

@refund-agent2
Copy link

refund-agent2 commented Mar 11, 2023 •
edited
Loading

I have included some of pazza's suggestions, I suppose it's ok to use this:

Go to Open trades to Accept the mediation proposal and wait for your peer's acceptance, if necessary. Click Reject if you disagree and explain your reasons on the mediation ticket.
If the trade has not been paid out in the next 48h, please inform your mediator on this ticket.
Keep in mind that the arbitrator can only make the payout of the trade amount + 1 security deposit. The other security deposit will be left unpaid.

Instructions about arbitration are already shown in the pop-up to accept arbitration, indicating the exact time to open arbitration.

@pazza83
Copy link

pazza83 commented Mar 11, 2023 •
edited
Loading

ACK, happy with @refund-agent2's wording above. Many thanks.

@ghost
Copy link
Author

ghost commented Mar 12, 2023 •
edited by ghost
Loading

Payout explanation & next steps revised text:
image

Mediation proposal with added arbitration button (disabled prior to timelock expiry):
image

@ghost ghost requested a review from refund-agent2 March 12, 2023 14:51
@refund-agent2
Copy link

refund-agent2 commented Mar 15, 2023 •
edited
Loading

ACK, thanks.

ripcurlx
ripcurlx approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.9.10 milestone Mar 27, 2023
@ripcurlx ripcurlx merged commit cf56ae3 into bisq-network:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.10
Development

Successfully merging this pull request may close these issues.
3 participants
@pazza83 @refund-agent2 @ripcurlx