Validate that XMR subaddress view key matches the main address #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to check the private view key is a valid scalar. The scalarmul will return invalid outputs for unreduced scalars, as noted in #6613. While Bisq could reduce the scalar on its end, Monero should never provide an unreduced scalar, so there's no benefit to supporting them (it just increases the likelihood of an error). |
|
@kayabaNerve Could you please ACK the last changes as well and I'll merge it into master? Thanks! |
|
LGTM |
HenrikJannsen
requested changes
Mar 29, 2023
core/src/test/java/knaccc/monero/address/WalletAddressTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Show resolved
Hide resolved
core/src/main/java/bisq/core/xmr/knaccc/monero/address/WalletAddress.java
Outdated
Show resolved
Hide resolved
|
@Boog900 Would you be able to review that PR as well? I am not familiar enough with Monero details. |
Boog900
reviewed
Mar 29, 2023
core/src/test/java/knaccc/monero/address/WalletAddressTest.java
Outdated
Show resolved
Hide resolved
Boog900
approved these changes
Mar 29, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6611
Resolves #6613 via 165f2d0
The XMR account can only be saved if the supplied view key matches the address.
Private view key -> generates public view key -> compare with main address part.