Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total revenue to burningmen view #6624

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Add total revenue to burningmen view #6624

merged 3 commits into from
Apr 2, 2023

Conversation

HenrikJannsen
Copy link
Collaborator

@HenrikJannsen HenrikJannsen commented Mar 31, 2023 •
edited
Loading

  • Add total revenue and total received BTC to burningmen view
  • Hide columns which are not essential

@HenrikJannsen
Add total revenue to burningman details.
aa5de89 
We do not add a column to the overview table because calculating the balance entries is expensive and doing it over all burningmen would take too long. There is headroom for performance improvements in that area...

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen
Copy link
Collaborator Author

HenrikJannsen commented Mar 31, 2023 •
edited
Loading

Before with all columns shown:
Screenshot 2023-03-31 at 18 29 36

Now with columns hidden + total revenue and total received BTC shown:
Screenshot 2023-03-31 at 19 48 00

@HenrikJannsen
Hide columns in burningman overview table which are not essential.
afe4bcc 
There is the small + icon on the right top of the table which allows to show the hidden columns.
Unfortunately this does not come with column names, so it's a bit ugly.

Here is a way how to adjust the context menu: https://gist.github.com/Roland09/d92829cdf5e5fee6fee9
Maybe any dev is motivated to improve that.
@HenrikJannsen HenrikJannsen force-pushed the add_total_revenue_to_burningmen_view branch from ff1948a to afe4bcc Compare March 31, 2023 11:36
@HenrikJannsen HenrikJannsen marked this pull request as draft March 31, 2023 11:51
@HenrikJannsen
Add total received BTC field
ee83607 
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen HenrikJannsen marked this pull request as ready for review March 31, 2023 12:47
ghost
ghost approved these changes Mar 31, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alejandrogarcia83
alejandrogarcia83 approved these changes Apr 2, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 8318867 into bisq-network:master Apr 2, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Apr 2, 2023
@HenrikJannsen HenrikJannsen deleted the add_total_revenue_to_burningmen_view branch May 4, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.10
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikJannsen @alejandrogarcia83