Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend instances in Apitest by CSV list in apitest.properties #6727

Conversation

alyokaz
Copy link
Contributor

@alyokaz alyokaz commented Jun 10, 2023

There's currently no way to suspend any subset of instances in debugging mode in Apitest.

This change enables any or all instances to be suspended in debugging mode by the inclusion of the instance name(s) in a CSV list in the apitest.properties file.

@alyokaz alyokaz force-pushed the enable-apitest-debugging-suspend branch from 0847e44 to fcab232 Compare June 10, 2023 11:17
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

apitest/src/main/java/bisq/apitest/linux/BisqProcess.java Outdated Show resolved Hide resolved
Enable instances to be suspended in debugging mode by the inclusion of the
instance name in a CSV list in apitest.properties
@alyokaz alyokaz force-pushed the enable-apitest-debugging-suspend branch from fcab232 to b5b68b5 Compare July 4, 2023 20:01
@alyokaz alyokaz requested a review from alvasw July 4, 2023 20:33
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit a3da020 into bisq-network:master Jul 6, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants