Download all P2P data before announcing P2P ready. #6946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvasw @HenrikJannsen Could any of you ACK this PR? Thank you! |
|
@HenrikJannsen should review this becaue he is more familiar with the P2P/DAO layer. |
|
The code change looks good to me but when testing with a fresh app i never got the DAO synced (stays in DAO synchronizing). This might be another bug, but we should figure it out before applying that. |
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BsqBlocks were being downloaded and processed as soon as the initial P2P data response was received, however there can be subsequent P2P data batches received which contain information needed by the DAO. Resulting in DAO out of sync error for new users.
Solution is to announce P2P ready once all the data has been received.
Closes #6823
Another problem identified & not yet fixed:
If the BTC blockchain is still being sync'd (typical for a new user) the download of BsqBlocks stalls after the first batch. Resulting in "Synchronizing DAO" not completing until the user restarts.