Restore QR code scanner feature for mobile notification pairing #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandrogarcia83
requested changes
Mar 27, 2024
There was a problem hiding this comment.
NACK
The CI build fails on macOS (see https://github.com/bisq-network/bisq/actions/runs/8447335400/attempts/1#summary-23137520876),
|
@alejandrogarcia83 I am not sure why that failed. It does not provide much detail. |
This restores the functionality that was removed in b5beea5. However, this implementation utilizes the JavaCV library rather than the webcam-capture library as discussed in bisq-network#4940. As a result, this should now provide macOS support.
This should hopefully resolve images failing to load from resources on Windows due to problems with imread encountering "can't open/read file: check file path/integrity".
When attempting to close the frame grabber from a separate thread, the application would crash due to a SIGSEGV.
devinbileck
force-pushed
the
scan-qr-code
branch
from
93d73b1 to
5f3f692
Compare
devinbileck
added a commit
to devinbileck/bisq
that referenced
this pull request
Jun 23, 2024
With the introduction of the javacv library when re-adding the QR code scanner feature for mobile notification pairing in bisq-network#7050, the Bisq binary increased to nearly 1 GB from its previous size of around 300 MB. When including the javacv-platform dependency, it pulls in binaries for all platforms. But it is possible to limit this by utilizing the gradle-javacpp platform plugin which by default will pull in binaries only for the current platform. Reference: https://github.com/bytedeco/gradle-javacpp#the-platform-plugin With this change, the included libs went from ~980 MB down to ~366 MB.
alejandrogarcia83
pushed a commit
that referenced
this pull request
Jun 24, 2024
With the introduction of the javacv library when re-adding the QR code scanner feature for mobile notification pairing in #7050, the Bisq binary increased to nearly 1 GB from its previous size of around 300 MB. When including the javacv-platform dependency, it pulls in binaries for all platforms. But it is possible to limit this by utilizing the gradle-javacpp platform plugin which by default will pull in binaries only for the current platform. Reference: https://github.com/bytedeco/gradle-javacpp#the-platform-plugin With this change, the included libs went from ~980 MB down to ~366 MB.
alejandrogarcia83
pushed a commit
that referenced
this pull request
Jun 24, 2024
With the introduction of the javacv library when re-adding the QR code scanner feature for mobile notification pairing in #7050, the Bisq binary increased to nearly 1 GB from its previous size of around 300 MB. When including the javacv-platform dependency, it pulls in binaries for all platforms. But it is possible to limit this by utilizing the gradle-javacpp platform plugin which by default will pull in binaries only for the current platform. Reference: https://github.com/bytedeco/gradle-javacpp#the-platform-plugin With this change, the included libs went from ~980 MB down to ~366 MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the functionality that was removed in b5beea5. This implementation utilizes the JavaCV library rather than the webcam-capture library for reasons discussed in #4940.
I have tested this on both Linux (Ubuntu 23.10) and macOS (Sonoma 14.4).