Tidy logback files & add space back to log pattern #7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uniformise the log patterns somewhat, by making the 'Logger' classname field width either 15 for the seednode & statsnode, or 40 for the other applications (lengthened from 30 in a few cases). Also clean up the logback XML files somewhat, in particular removing references to the old Thali (thaliproject/Tor_Onion_Proxy_Library) Tor library, which was replaced years ago with our own fork of NetLayer (https://github.com/cd2357/netlayer). Finally, add a missing space back to the log pattern for bisq-desktop, to prevent DEBUG, ERROR or TRACE lines appearing as follows: ... [JavaFX Application Thread] ERRORb.c.s.CommonSetup: ... (It isn't clear whether this recently introduced behaviour was really intentional, though it did prevent two consecutive spaces appearing in the majority INFO log lines.)
stejbac
force-pushed
the
add-missing-space-to-log-pattern
branch
from
5581ed2 to
92da795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniformise the log patterns somewhat, by making the
Loggerclassname field width either 15 for the seednode & statsnode, or 40 for the other applications (lengthened from 30 in a few cases).Also clean up the logback.xml files somewhat, in particular removing references to the old Thali Tor library, which was replaced years ago with our own fork of NetLayer.
Finally, add a missing space back to the log pattern for bisq-desktop, to prevent
DEBUG,ERRORorTRACElines appearing as follows:(It isn't clear whether this recently introduced behaviour was really intentional, though it did prevent two consecutive spaces appearing in the majority
INFOlog lines.)