Resolve issues with javacv #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am looking into why this is still failing. |
HenrikJannsen
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
From build error output:
QrCodeProcessorTest > process_ValidQrCodeFrame_ReturnsDecodedText() FAILED
java.lang.UnsatisfiedLinkError at QrCodeProcessorTest.java:41
Caused by: java.lang.UnsatisfiedLinkError at QrCodeProcessorTest.java:41
QrCodeProcessorTest > process_NonQrCodeFrame_ReturnsEmptyOptional() FAILED
java.lang.RuntimeException at QrCodeProcessorTest.java:52
Caused by: java.lang.UnsatisfiedLinkError at QrCodeProcessorTest.java:52
QrCodeProcessorTest > process_InvalidFrame_ReturnsEmptyOptional() FAILED
java.lang.RuntimeException at QrCodeProcessorTest.java:68
Caused by: java.lang.UnsatisfiedLinkError at QrCodeProcessorTest.java:68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the UnsatisfiedLinkError encountered on macOS in #7166.
It should also further reduce the bundled javacv library size. Only my linux machine, the total included libs are now down to ~323 MB.