API PR part 2/2, adding the enableApi switch #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
Signed-off-by: Mike Rosseel <mike@eon-consult.be> Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
Signed-off-by: Mike Rosseel <mike@eon-consult.be> Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
This also adds a dependency on the bisq-api project, using jitpack. The core dependency is excluded in the bisq-api dependency to avoid duplicate classes in the shaded.jar. When the bisq-api is stable the SNAPSHOT version should be changed to a release version. Signed-off-by: Mike Rosseel <mike@eon-consult.be>
|
As discussed in a voice chat we add the UI sopport to the API project to not introduce dependencies to the API into the exchange project. I will close that and looking forward for the API project to get aded. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bisq-api dependency can be found here, on the master branch: https://github.com/mrosseel/bisq-api