-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement moderator view #1013
Merged
alvasw
merged 38 commits into
bisq-network:main
from
HenrikJannsen:implement_moderator_view
Jul 17, 2023
Merged
Implement moderator view #1013
alvasw
merged 38 commits into
bisq-network:main
from
HenrikJannsen:implement_moderator_view
Jul 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default networkId is using the default key ID. It usually is not used for sending private mailbox messages, but in case it would we would have used the "default" value for it and all nodes would try to decrypt the encrypted message (by looking up the key with that id). To avoid that, we use now a random keyId prefixed with "default_" created at first start and persisted.
This allows us to verify the senders pubkey at higher level APIs (e.g. used for bonded roles to verify that the sender is the owner of the profile ID /pubkeyhash)
… that would create a new map entry for each republish call
Use cheaper compare properties than serialize protobuf data. Use Collections.sort instead of the sort method.
…ing data. Change API for removeAuthorizedData
Add show/hide info toggle to registration view
alvasw
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.