Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement moderator view #1013

Merged
merged 38 commits into from
Jul 17, 2023

Conversation

HenrikJannsen
Copy link
Contributor

No description provided.

The default networkId is using the default key ID. It usually is not used for sending private mailbox messages, but in case it would we would have used the "default" value for it and all nodes would try to decrypt the encrypted message (by looking up the key with that id).
To avoid that, we use now a random keyId prefixed with "default_" created at first start and persisted.
This allows us to verify the senders pubkey at higher level APIs (e.g. used for bonded roles to verify that the sender is the owner of the profile ID /pubkeyhash)
… that would create a new map entry for each republish call
Use cheaper compare properties than serialize protobuf data.
Use Collections.sort instead of the sort method.
…ing data.

Change API for removeAuthorizedData
Add show/hide info toggle to registration view
@HenrikJannsen HenrikJannsen marked this pull request as ready for review July 16, 2023 18:26
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit b03b8ac into bisq-network:main Jul 17, 2023
@HenrikJannsen HenrikJannsen deleted the implement_moderator_view branch July 18, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants