Unit test payment method accounts #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvasw
requested changes
Aug 3, 2023
account/build.gradle
Outdated
| @@ -11,4 +11,6 @@ dependencies { | |||
|
|
|||
| implementation 'network:network' | |||
| implementation libs.google.guava | |||
|
|
|||
| testImplementation libs.assertj.core | |||
There was a problem hiding this comment.
This is not needed because AssertJ is already defined in:
Discovered and fixed some issues along the way. The most important is the removal of HRK as supported currency in Revolut and Wise. HRK was replaced by the Euro in 2023. The presence of HRK was preventing the Revolut and Wise FiatPaymentRails enums from being properly initialized (they were throwing NullPointerException, I think because HRK wasn't found in the currency repository).
namloan
force-pushed
the
payment_accounts_tests
branch
from
538f8d3 to
8fa8b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered and fixed some issues along the way. The most important is the removal of HRK as supported currency in Revolut and Wise. HRK was replaced by the Euro in 2023. The presence of HRK was preventing the Revolut and Wise FiatPaymentRails enums from being properly initialized (they were throwing NullPointerException).
#909