Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix learn view issues with resizing and texts and buttons out of alignment #1234

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Fix learn view issues with resizing and texts and buttons out of alignment #1234

merged 7 commits into from
Oct 2, 2023

Conversation

aspire2dev
Copy link
Contributor

Additional to the learn view, changes to GridPaneUtil to better render other views. Adapting DashboardView and BisqEasyOnboardingView to the changes in GridPaneUtil.

This covers part of the work for issue #1218 with the move towards Text and TextFlow for the info texts.

…nment.

Additional to the learn view, changes to GridPaneUtil to better render other views.
Adapting DashboardView and BisqEasyOnboardingView to the changes in GridPaneUtil.
@HenrikJannsen
Copy link
Contributor

Icon at dashboard is wrong and some paddings are different as it was before.
Please make screenshots from main and your version and overlap them in a graphic editor to see if all matches.

Screenshot 2023-09-29 at 11 40 05 Screenshot 2023-09-29 at 11 40 23 Screenshot 2023-09-29 at 11 39 36 Screenshot 2023-09-29 at 11 39 05

@HenrikJannsen
Copy link
Contributor

Also gap of icon to headline in learn is a bit large (was before as well). You can reduce it by 10 px. And in trade protocol make it 5 px larger.

@HenrikJannsen
Copy link
Contributor

Here it does not align:
Screenshot 2023-09-29 at 11 28 06

Adjustment to accomodate different icon gap sizes to the headline section. Adjusted BisqEasyOnboardingView and DashboardView.
@aspire2dev
Copy link
Contributor Author

Icon at dashboard is wrong and some paddings are different as it was before. Please make screenshots from main and your version and overlap them in a graphic editor to see if all matches.
Screenshot 2023-09-29 at 11 40 05 Screenshot 2023-09-29 at 11 40 23 Screenshot 2023-09-29 at 11 39 36 Screenshot 2023-09-29 at 11 39 05

Fixed this issue. Learn is not pixel perfect to what was on the previous version because of the different spacing between the Text and the Label components. If a comparison to the original is done, the buttons will look to be misaligned, but they have the exact same distance between the bottom of the text and the end of the box pane

@aspire2dev
Copy link
Contributor Author

Also gap of icon to headline in learn is a bit large (was before as well). You can reduce it by 10 px. And in trade protocol make it 5 px larger.

Done

@aspire2dev
Copy link
Contributor Author

Here it does not align: Screenshot 2023-09-29 at 11 28 06

This will be fixed on another branch.

Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 0710a16 into bisq-network:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants