-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix learn view issues with resizing and texts and buttons out of alignment #1234
Fix learn view issues with resizing and texts and buttons out of alignment #1234
Conversation
…nment. Additional to the learn view, changes to GridPaneUtil to better render other views. Adapting DashboardView and BisqEasyOnboardingView to the changes in GridPaneUtil.
desktop/src/main/java/bisq/desktop/common/utils/GridPaneUtil.java
Outdated
Show resolved
Hide resolved
Also gap of icon to headline in learn is a bit large (was before as well). You can reduce it by 10 px. And in trade protocol make it 5 px larger. |
Adjustment to accomodate different icon gap sizes to the headline section. Adjusted BisqEasyOnboardingView and DashboardView.
Done |
desktop/src/main/java/bisq/desktop/common/utils/GridPaneUtil.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/content/academy/overview/OverviewAcademyView.java
Outdated
Show resolved
Hide resolved
…moving validation for image gap <= zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Additional to the learn view, changes to GridPaneUtil to better render other views. Adapting DashboardView and BisqEasyOnboardingView to the changes in GridPaneUtil.
This covers part of the work for issue #1218 with the move towards Text and TextFlow for the info texts.