Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app window icons #1296

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Update app window icons #1296

merged 1 commit into from
Oct 23, 2023

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Oct 23, 2023 •
edited
Loading

  • Optimize for better visualization:
    • Green over green. The previous icon had two tones of green.
    • The previous icon had some gradient, which made the icon seem more blurred at low resolution.
    • Circle inside a circle. The Bisq logo is almost a circle, thus it seems redundant to draw a circle outside of the logo.
  • Reduce size by a factor of around 5.
  • Unify with the current icon being used (Matrix, Bisq web, GitHub).

Towards #1211

@axpoems
Update app window icons
a4f7769 
* Optimize for better visualization:
	* Green over green. The previous icon had two tones of green.
	* The previous icon had some gradient, which made the icon seem more blurred at low resolution.
	* Circle inside a circle. The Bisq logo is almost a circle, thus it seems redundant to draw a circle outside of the logo.
* Reduce size by a factor of around 5.
* Unify with the current icon being used (Matrix, Bisq web).

Towards bisq-network#1211
HenrikJannsen
HenrikJannsen approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alvasw
alvasw reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit b47ec2b into bisq-network:main Oct 23, 2023
12 checks passed
@axpoems axpoems deleted the design-app-window-icons branch October 24, 2023 05:23
@axpoems axpoems mentioned this pull request Nov 21, 2023
Closed
@axpoems axpoems mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw left review comments

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axpoems @alvasw @HenrikJannsen