Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization, signing and notarization for macOS binary #295

Merged

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented May 3, 2022

ATM matches our current Bisq 1 design (needs @pedromvpg love)

Bildschirmfoto 2022-05-03 um 12 33 35
Bildschirmfoto 2022-05-03 um 12 33 46

Example notarized build: https://www.dropbox.com/s/rsjcf5j5p9cyrdi/Bisq%202-1.0.0-notarized-stapled.dmg?dl=0

@ripcurlx
Copy link
Contributor Author

ripcurlx commented May 3, 2022

I use project properties for code signing now to prevent CI issues. If code signing is needed run ./gradlew jpackage -PsignBinary

Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984
Copy link
Contributor

Could we apply Pedros new design? Not urgent at all, and not signed off from Pedro if that will be the final design...

https://xd.adobe.com/view/a83c2327-4730-4ec2-8938-e318b2749588-fd6f
Screenshot 2022-05-05 at 11 09 46

@chimp1984 chimp1984 merged commit ad69a4c into bisq-network:main May 5, 2022
@ripcurlx
Copy link
Contributor Author

ripcurlx commented May 5, 2022

Could we apply Pedros new design? Not urgent at all, and not signed off from Pedro if that will be the final design...

https://xd.adobe.com/view/a83c2327-4730-4ec2-8938-e318b2749588-fd6f Screenshot 2022-05-05 at 11 09 46

I did try to contact @pedromvpg already regarding new assets. I'll adapt it as soon I have the final assets. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants