Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve I2P log handling #63

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Improve I2P log handling #63

merged 1 commit into from
Feb 4, 2022

Conversation

alkum
Copy link
Contributor

@alkum alkum commented Feb 3, 2022

Customize and document the i2p log manager.

Also handle an edge case whereby a closed socket was being closed again.

@alkum
Improve I2P log handling
f7edb55 
Customize and document the i2p log manager.
chimp1984
chimp1984 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should continue to look how to get the logs into our data directory and not in the project root.

i2p/src/main/java/bisq/i2p/I2pClient.java Show resolved Hide resolved
@chimp1984 chimp1984 merged commit 920e77e into bisq-network:main Feb 4, 2022
@alkum alkum deleted the i2-logging branch February 4, 2022 13:50
@alkum alkum mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkum @chimp1984