Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for out of order events #944

Merged

Conversation

HenrikJannsen
Copy link
Contributor

@HenrikJannsen HenrikJannsen commented Jun 20, 2023

Based on #943

Add generics support FsmModel.
Enable commented out tests
We cannot use the state enum ordinal as we should not rely on the State ordinal. The transition definition is the only relevant data.
Also, State can be implemented in a class as well, it is not mandatory an enum.

The client code is responsible for persisting the 2 hashsets to ensure that pending events are correctly handled after restart.
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 5a8850b into bisq-network:main Jun 29, 2023
@HenrikJannsen HenrikJannsen deleted the add_handling_for_out_of_order_events branch July 1, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants