Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 46 #1276

Closed
alvasw opened this issue Apr 10, 2023 · 4 comments
Closed

For Cycle 46 #1276

alvasw opened this issue Apr 10, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Apr 10, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 3214.29
  • USD requested: 2700
  • BSQ rate: 0.84 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 45 #1254

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
OutboundConnectionChannel: Get address from capability dev bisq-network/bisq2#704
ServerChannel: Add onServerReadyListener dev bisq-network/bisq2#705 Others can register a listener to get notified when the server is ready.
ServerChannel: Set ServerSocketChannel to non-blocking after binding port dev bisq-network/bisq2#706
Implement OutboundConnectionManager dev bisq-network/bisq2#707 The OutboundConnectionManager:
  • creates new connections asynchronously
  • tracks pending and open connections
  • initiates the handshake
  • validates other peer's handshake response
Implement OutboundConnectionMultiplexer dev bisq-network/bisq2#708 The OutboundConnectionMultiplexer multiplexes all outbound connections on a single thread.
InboundConManager: Use thread-safe lists and maps to track connections dev bisq-network/bisq2#709
InboundConnectionsManager: Create address to connection mapping dev bisq-network/bisq2#710
InboundConnectionsManager: Perform constant peer connected check dev bisq-network/bisq2#711
InboundConnectionManager: Add getConnectionByAddress lookup dev bisq-network/bisq2#712
InboundConnectionsManager: Add getAllInboundConnections dev bisq-network/bisq2#713 OutboundConnectionManager: Bi-directional address to channel mapping
OutboundConnectionManager: Map channel to connection dev bisq-network/bisq2#715
OutboundConnections: Migrate from capability to address dev bisq-network/bisq2#716
OutboundConnectionManager: Handle immediate connect dev bisq-network/bisq2#717 A SocketChannel in non-blocking mode can establish a connection immediately. This usually happens with local connections.
OutboundConnectionManager: Handle remote peer offline case dev bisq-network/bisq2#718
OutboundConnectionManager: Add getAllOutboundConnections dev bisq-network/bisq2#719
OutboundConnectionManager: Pass messages to Node after successful handshake dev bisq-network/bisq2#720
OutboundConnectionMultiplexer: Add getAllOutboundConnections dev bisq-network/bisq2#726
OutboundConnectionMultiplexer: Handle NIO CancelledKeyException dev bisq-network/bisq2#727
ServerChannel: Connection lookups and getAllInboundConnections dev bisq-network/bisq2#728
Implement PeerConnectionsManager dev bisq-network/bisq2#729 The PeerConnectionsManager manages inbound and outbound connections, and hides the complexity. Others can lookup connections.
Wallets: Remove LegacyJsonRpcClient dev bisq-network/bisq2#731
Wallets: Remove legacy JsonRpcCalls dev bisq-network/bisq2#732
Wallets: Remove old legacy JSON-RPC exceptions dev bisq-network/bisq2#733
Move RpcConfig from wallets.core to wallets.json_rpc dev bisq-network/bisq2#734
Move RpcClientFactory from wallets.core to wallets.json_rpc dev bisq-network/bisq2#735
Migrate to RpcCallFailureException from wallets.json_rpc dev bisq-network/bisq2#736
WalletNotInitializedException: Remove unused constructors dev bisq-network/bisq2#737
BitcoindCreatListIntegrTests: Remove unused minerWallet field dev bisq-network/bisq2#738
ElectrumWallet: Remove unused receiveAddresses arg dev bisq-network/bisq2#739
BitcoindCreatListIntegrTests: Remove MalformedURLException from signature dev bisq-network/bisq2#740
dev 2700 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Apr 10, 2023
@MwithM MwithM added this to the Cycle 46 milestone Apr 10, 2023
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request. Please submit your CR to the DAO for voting and post the TX ID here afterwards. Thanks!

@alvasw
Copy link
Author

alvasw commented Apr 16, 2023

89c16ecd29bdd0b512259d042e762aad0e1ea28ef2f2d619dcd14c17fbc1522e

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Issuance by Team:

team amount BSQ amount USD
dev 3214.29 2700.00

Total Issuance: 3214.29 BSQ (equivalent to: 2700.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Apr 26, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants