Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 45 #1254

Closed
alvasw opened this issue Mar 10, 2023 · 4 comments
Closed

For Cycle 45 #1254

alvasw opened this issue Mar 10, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Mar 10, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8791.21
  • USD requested: 8000
  • BSQ rate: 0.91 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 44 #1235

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
PR Review: [1.9.10] Fix unhandled exception in DAO Governance view. dev bisq-network/bisq#6575
PR Review: Fix NPE at trade payment started event. dev bisq-network/bisq#6585
PR Review: Fix exception due to missing read lock. dev bisq-network/bisq#6588
PR Review: Payout tx confidence should be after block height of deposit. dev bisq-network/bisq#6590
PR Review: Speed up BSQ tx view load dev bisq-network/bisq#6600
ScryptUtil: Fix thread leak dev bisq-network/bisq#6556 Each time someone called the static method ScryptUtil.deriveKeyWithScrypt(...) a new worker pool was created. The worker pool was never shutdown.
ExportJsonFilesService: Shutdown Executor dev bisq-network/bisq#6557
Broadcaster: Shutdown executor dev bisq-network/bisq#6558
Remove unused Utilities.getScheduledThreadPoolExecutor(...) dev bisq-network/bisq#6559
Delagate thread pool shutdown to Guava MoreExecutors dev bisq-network/bisq#6560
Centralize executor shutdown and await dev bisq-network/bisq#6561
Move SingleThreadExecutors to its own Utils class dev bisq-network/bisq#6562
GitHub Actions: Target checkout action tag dev bisq-network/bisq#6563
Checkout (CI): Don't fetch full history dev bisq-network/bisq#6564
GitHub Actions: Target setup-java action tag dev bisq-network/bisq#6565
CI: Use official Gradle Build Action dev bisq-network/bisq#6566
Gradle: Create bisq.java-conventions precompiled script dev bisq-network/bisq#6567
Gradle apply central bisq java conventions dev bisq-network/bisq#6568
Connection: Pass uid to executor service name dev bisq-network/bisq#6569
  • Connection: Pass uid to executor service name
  • Connection: Rename singleThreadExecutor to executorService
NetworkNode: Move server threading logic to server dev bisq-network/bisq#6576
Server: Switch to atomic isStopped boolean dev bisq-network/bisq#6577
Server: Extract isStopped check to method dev bisq-network/bisq#6578
Server: Remove redundant isStopped boolean dev bisq-network/bisq#6580
Rename NetworkFilter to BanFilter dev bisq-network/bisq#6581
Remove unused ConnectionListener.onError(...) method dev bisq-network/bisq#6582
Decouple NetworkStatistics from UI thread [1/2] dev bisq-network/bisq#6586
Add missing dependencies to integration test sourceset dev bisq-network/bisq2#648
Implement ConnectionHandshakeInitiator dev bisq-network/bisq2#652
Write NetworkEnvelopeSocketChannelTests dev bisq-network/bisq2#653
Remove old NodeServerSocketChannel dev bisq-network/bisq2#654
Move NetworkEnvelopeSocketChannel into HandshakeResponder dev bisq-network/bisq2#657
InboundConnectionsManager: Get addresses from Capabilities instead from SocketChannel dev bisq-network/bisq2#658
InboundConnectionsManager: Close connection if already connected to peer dev bisq-network/bisq2#659
Implement asynchronous ServerChannel dev bisq-network/bisq2#660 The ServerChannel multiplexes many inbound connections on a single thread.
Remove commented out PersistenceIntegrationTest dev bisq-network/bisq2#663
protobuf: Add generated test source to srcDirs dev bisq-network/bisq2#664
Implement PersistableStoreFileManager dev bisq-network/bisq2#665 The PersistableStoreFileManager can create, the needed, directory hierarchy; backup the current store file; and rename the temp file to the current file.
PersistableStoreFileManager: Throw CouldNotCreateParentDirs dev bisq-network/bisq2#666
Remove too generic PersistableStoreFileBackupFailed exception dev bisq-network/bisq2#667
PersistStoreFileManager: Only backup file if present dev bisq-network/bisq2#668
PerStoreFileManager: Support restore backup dev bisq-network/bisq2#669
Implement PersistableStoreReaderWriter dev bisq-network/bisq2#670
Make PersistableStoreReaderWriter thread-safe dev bisq-network/bisq2#671
Persistence: Switch to PersistableStoreReaderWriter dev bisq-network/bisq2#672
Persistence: Make persist method return void dev bisq-network/bisq2#673
Persistence: Remove unused lock and atomic reference dev bisq-network/bisq2#674
Persistence: Use typed Paths for filesystem paths dev bisq-network/bisq2#675
Persistence: Make persist method visibility protected dev bisq-network/bisq2#676
Persistence: Use single thread executor service dev bisq-network/bisq2#677
Gradle: Move Mockito to version catalog dev bisq-network/bisq2#679
Do not create a new daemon thread in each shutdown routine dev bisq-network/bisq2#680
ExecutorFactory: Add cached thread pool with maxPoolSize and keepAlive dev bisq-network/bisq2#681 The caller can set the name, maxPoolSize and keepAliveTimeInSeconds with the new factory method.
DaoBridgeHttpService: Share thread pool across all http requests dev bisq-network/bisq2#682 Each http request created a new thread pool, and the thread pool was never shutdown. This change switched to a shared thread pool that handles 4 request in parallel. A thread shuts itself down if it's idle for 60 seconds.
OpenOfferService: Make executorService non-static dev bisq-network/bisq2#683 Create a non-static executorService and shut it down later.
Observable: Make observers field final dev bisq-network/bisq2#684 We create the set upon class construction, and it's never null. So, we can make the field final and remove all null-checks.
ObservableArray: Make observers field final dev bisq-network/bisq2#685 We create the set upon class construction, and it's never null. So, we can make the field final and remove all null-checks.
ObservableArray: Remove unused generic variable dev bisq-network/bisq2#686
dev 8000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Mar 10, 2023
@MwithM MwithM added this to the Cycle 45 milestone Mar 10, 2023
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request. Please submit your CR to the DAO for voting and post your transaction ID here afterwards. Thanks!

@alvasw
Copy link
Author

alvasw commented Mar 16, 2023

77a6cb34ca316e708adf38c9b546e61d6b8a8e84d7aa2ec262d8e39a25aa5a84

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 24, 2023
@ghost
Copy link

ghost commented Mar 24, 2023

Issuance by Team:

team amount BSQ amount USD
dev 8791.21 8000.00

Total Issuance: 8791.21 BSQ (equivalent to: 8000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Mar 24, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants