Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple NetworkStatistics from UI thread [1/2] #6586

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Feb 14, 2023

The NetworkStatisticsService is an attempt to decouple the network statistic computation from the UI thread. Here, the NetworkStatisticsService schedules repeating tasks on a ScheduledExecutorService.

@alvasw alvasw marked this pull request as draft February 14, 2023 17:54
@alvasw alvasw force-pushed the implement_network_statistics_service branch 2 times, most recently from aad2273 to fb634c8 Compare February 15, 2023 17:56
@alvasw alvasw marked this pull request as ready for review February 15, 2023 18:05
@alejandrogarcia83
Copy link
Contributor

Hi @alvasw!
The other PR merges created a merge conflict. Could you please rebase this PR? Thank you!

The NetworkStatisticsService is an attempt to decouple the network
statistic computation from the UI thread. Here, the
NetworkStatisticsService schedules repeating tasks on a
ScheduledExecutorService.
@alvasw alvasw force-pushed the implement_network_statistics_service branch from fb634c8 to 4c6c910 Compare February 15, 2023 18:36
@alvasw
Copy link
Contributor Author

alvasw commented Feb 15, 2023

Rebased

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit d83a205 into bisq-network:master Feb 18, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Feb 27, 2023
@alvasw alvasw deleted the implement_network_statistics_service branch April 8, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants