For Cycle 44

[alvasw]

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

• BSQ requested: 11428.57
• USD requested: 8000
• BSQ rate: 0.7 USD per BSQ
• Previous compensation request (if applicable): For Cycle 43 #1216

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title	Team	USD	Link	Notes
Create build.gradle for assets module	dev		bisq-network/bisq#6521
Create build.gradle for cli module	dev		bisq-network/bisq#6522
Create build.gradle for daemon module	dev		bisq-network/bisq#6523
Centralize all ExecutorService creations in Utilities	dev		bisq-network/bisq#6540
DaoStateStorageService: Don't call executorService.shutdown() twice	dev		bisq-network/bisq#6541
Connection: Close protoOutputStream before closing socket	dev		bisq-network/bisq#6542	The protoOutputStream depends on the sockets OutputStream. Closing the socket before closing the protoOutputStream will always trigger an IOException.
Sychronized proto output stream try graceful shutdown first	dev		bisq-network/bisq#6543	ProtoOutputStream is not thread-safe. This change tries to close the stream on the same thread first. Before forcefully killing it after a timeout.
Make ProtoOutputStream thread-safe	dev		bisq-network/bisq#6547	Before SynchronizedProtoOutputStream created a new thread and made a blocking call to ProtoOutputStream.writeEnvelope(...). Each connection had an instance of SynchronizedProtoOutputStream, so we had a redundant thread per connection. This change makes ProtoBufOutputStream thread-safe and reduces the number of thread per connection as a side effect.
DaoStateStorageService: Fix shutdown data corruption bug	dev		bisq-network/bisq#6548	The DaoStateStorageService submits tasks to a daemon thread executor service. The JVM continues to execute threads until all non-daemon threads have terminated. So the JVM will kill the DaoStateStorageService during write requests leading to data corruption. This change uses a non-daemon thread executor service at waits during shutdown until all data is written to disk.
Fix MailboxMessageService thread leak/explosion	dev		bisq-network/bisq#6549	Each time when MailboxMessageService.onAdded(...) got called with multiple mailbox entries a new thread got created. That thread was never shutdown. This change explicitly creates a new Thread and sets its result with a SettableFuture. After its computation the thread terminates.
XmrTxProofRequest: Shutdown executor service in terminate()	dev		bisq-network/bisq#6550
Fix BurningManAccountingStore data races	dev		bisq-network/bisq#6551	Multiple threads read and write to the accounting blocks list causing data races. Luckily, the LinkedList threw a ConcurrentModificationException to limit damage. Now, a ReadWriteLock protects the LinkedList against data races. Multiple threads can read the list at the same time but only one thread can write to it. Other writing threads wait until it's their turn.
Fix Electrum empty password failures	dev		bisq-network/bisq2#621	When the Electrum wallet is not encrypted we have to ommit the password field in all JSON requests. Sending an empty string causes the RPC calls to fail.
Electrum: Reenable auto balance update	dev		bisq-network/bisq2#622
Socks5/TorSocketChannel: Return SocketChannel	dev		bisq-network/bisq2#624
Refactor ConnectionHandshakeResponder and write tests	dev		bisq-network/bisq2#627
Gradle: Add integration source set to all modules	dev		bisq-network/bisq2#628	Add support for integration source set Add independent 'integrationTest' test task
Network: Move IntegrationTests to its source set	dev		bisq-network/bisq2#629
Remove wallets:api module	dev		bisq-network/bisq2#630
Bitcoind: Move integrationTests to its sourceset	dev		bisq-network/bisq2#631
Electrum: Move integration tests to its own sourceset	dev		bisq-network/bisq2#632
Bitcoind: Remove regtest dependency for unit tests	dev		bisq-network/bisq2#633
Elementsd: Move integration tests into own sourceset	dev		bisq-network/bisq2#634
Bitcoind: Remove bisq integration test block	dev		bisq-network/bisq2#635
Elementsd: Remove bisq integration tests block	dev		bisq-network/bisq2#636
Gradle BisqPlugin: Remove dynamic integration runs	dev		bisq-network/bisq2#637
Gradle: Apply bisq.java-library plugin to all modules	dev		bisq-network/bisq2#638
Gradle: Remove BisqPlugin	dev		bisq-network/bisq2#639
Gradle: Apply bisq.java-integration-tests only when needed	dev		bisq-network/bisq2#640
Reenable parallel Gradle builds	dev		bisq-network/bisq2#641
Implement nio NetworkEnvelopeDeserializer	dev		bisq-network/bisq2#642
Implement async ProtoBufMessageLengthWriter	dev		bisq-network/bisq2#643
NetworkEnvelopeDeserializer: Return parsed protobuf message	dev		bisq-network/bisq2#644
ConnectionHandshakeResponder: Return request and response	dev		bisq-network/bisq2#645
Implement NetworkEnvelopeSocketChannel	dev		bisq-network/bisq2#646	The NetworkEnvelopeSocketChannel can send and receive NetworkEnvelopes over SocketChannels.
Implement async InboundConnectionsManager	dev		bisq-network/bisq2#647	The InboundConnectionsManager uses a selector to multiplex multiple socket channels on a single thread. It accepts and performs the handshake asynchronously.
	dev	8000		Total for items above.

[ripcurlx]

As dev team lead I approve this compensation request for dev.

[alvasw]

d58890cf13f512b9ad55d7cda35f3efb53811b7849806da3f9b579625efc8d12

[ghost]

Issuance by Team:

team	amount BSQ	amount USD
dev	11428.57	8000.00

Total Issuance: 11428.57 BSQ (equivalent to: 8000.00 USD)

[MwithM]

Closed as completed