Fix BurningManAccountingStore data races #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvasw
force-pushed
the
fix_burningman_accounting_store_data_races
branch
from
dfad3bb to
cc95f53
Compare
alvasw
changed the title
alvasw
force-pushed
the
fix_burningman_accounting_store_data_races
branch
from
cc95f53 to
04343bf
Compare
alvasw
changed the title
alvasw
force-pushed
the
fix_burningman_accounting_store_data_races
branch
from
04343bf to
608e42d
Compare
Multiple threads read and write to the accounting blocks list causing data races. Luckily, the LinkedList threw a ConcurrentModificationException to limit damage. Now, a ReadWriteLock protects the LinkedList against data races. Multiple threads can read the list at the same time but only one thread can write to it. Other writing threads wait until it's their turn. Fixes bisq-network#6545
alvasw
force-pushed
the
fix_burningman_accounting_store_data_races
branch
from
608e42d to
4779c82
Compare
alvasw
changed the title
alvasw
changed the title
This was referenced Feb 9, 2023
Closed
ghost
mentioned this pull request
Closed
This was referenced Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple threads read and write to the accounting blocks list causing data races. Luckily, the LinkedList threw a ConcurrentModificationException to limit damage. Now, a ReadWriteLock protects the LinkedList against data races. Multiple threads can read the list at the same time but only one thread can write to it. Other writing threads wait until it's their turn.
Fixes #6545