For Cycle 7

[bodymindarts]

Summary

This request includes contributions delivered in both Cycle 6 and Cycle 7 because I missed the deadline for Cycle 6.

BSQ requested: 16658BSQ total
Cycle 6: $4000 (@ 1 BSQ = 1 USD) => 4000BSQ
Cycle 7: $10000 (@ 1 BSQ = 0.79 USD) => 12658BSQ

Contributions delivered

Cycle 6

• Some small PRs to improving the code relating to the BSFormatter class. [ 1500 USD]
  Make stateless BSFormatter functions static and remove dead code bisq#3239
  Extract helper classes from BSFormatter bisq#3244
• Discovered one of the hashing mechanisms used in Bisq is unstable due to its dependency on protobufs which is a non-deterministic serialization format. My investigation revealed it is dangerous but we are okay for the time being thanks to an implementation detail of the java protobuf lib findings of investigation [ 2500 USD ]

Cycle 7

• Discovered a critical bug in a different hashing mechanism that was acute [ 2500 USD ]
• Re-implemented Bisq Markets API using caching proxy with @wiz Re-implement Markets API service with pre-caching proxy + risq backend bisq-markets#20. This was to solve immediate acute issues with responsiveness and down time [5000]
• Implemented a service check to perform ping/pong validation of responsiveness of Bisq nodes for @wiz to monitor the uptime of seednodes on his monitoring alerts system [ 2500 USD ]
  Readme: https://github.com/bodymindarts/risq/#node-checker
  Code: https://github.com/bodymindarts/risq/blob/master/src/checker.rs
  Execution happens from @wiz' monitoring code which is closed source

[chimp1984]

Could you separate the risq related issues in a separate compensation request?

[ripcurlx]

• implemented a new Bisq Markets API service together with @wiz to fix uptime and performance issues [ 4000 USD ]

Because of the size of this PR I'm not sure if I'm able to ACK it and merge it in-time to be up for compensation. Please check before you finally submit your compensation request if everything is delivered.

[ripcurlx]

• Some small PRs to improving the code relating to the BSFormatter class. [ 1500 USD]

Could you please link the PRs/commits so it is easier to evaluate for all stakeholders. Thanks!

[ripcurlx]

Could you separate the risq related issues in a separate compensation request?

I think it would be great to separate it out as @chimp1984 mentioned, as there was no consensus yet on the proposal bisq-network/proposals#125

[ripcurlx]

• Implemented a service check to perform ping/pong validation of responsiveness of Bisq nodes for @wiz to monitor the uptime of seednodes on his monitoring alerts system [ 2500 USD ]

Is the code implemented somewhere publicly available for review?

[bodymindarts]

• Some small PRs to improving the code relating to the BSFormatter class. [ 1500 USD]

Could you please link the PRs/commits so it is easier to evaluate for all stakeholders. Thanks!

These are the merged PRs.
bisq-network/bisq#3239
bisq-network/bisq#3244
They are step 1-2 of a multi step refactoring. This was supposed to be the final state:
bisq-network/bisq#3230 (Rejected because too large, hence the break up)
And this is step 3 but it didn't get merged due to lack of reviewers:
bisq-network/bisq#3253

Hence I'm only billing for the first 2. Just referencing all for documentation.

• Implemented a service check to perform ping/pong validation of responsiveness of Bisq nodes for @wiz to monitor the uptime of seednodes on his monitoring alerts system [ 2500 USD ]

Is the code implemented somewhere publicly available for review?

Readme: https://github.com/bodymindarts/risq/#node-checker
Code: https://github.com/bodymindarts/risq/blob/master/src/checker.rs
Execution happens from @wiz' monitoring code which is closed source

[bodymindarts]

PROPOSAL TX: f5bd0fb074b47ff9d19e7bf76d5aa5aa72a6ee43336425b63a9f94bd6428c145

[bodymindarts]

@ripcurlx I have removed the line item referring to the poc for now, since you haven't had the time to form an opinion. I look forward to reading your concerns so that I can address them as per https://docs.bisq.network/proposals.html.

[ripcurlx]

• Reduce bs formatter interface bisq#3253

Please remove this not merged PR from your compensation request as it might confuse stakeholders when reviewing your request.

[bodymindarts]

• bisq-network/bisq#3253

Please remove this not merged PR from your compensation request as it might confuse stakeholders when reviewing your request.

Removed the PR section as I'm linking to the PRs in the line items

[chimp1984]

Feel free to make a request at next cycle again for the delivered non-risq related work. I personally do not support the risq related work but would support your other request. But as you did not split it up I could not upvote the non-risq related contributions.

[bodymindarts]

@chimp1984 This makes no sense to me.
You upvoted @wiz contribution request and 57% (5700/9873) of it was itemized as the re-implementation of the markets api. So clearly you have support risq related work.

The risq project is reliably serving > 1 mio requests per day for Bisq. The markets api is an important part of the supporting infrastructure of the Bisq network which was frequently crashing previously. Even if this isn't the best long-term solution its a pretty good stop-gap for the time being.

In addition the seednode checker has detected offline seednodes multiple times in real-time where previously there was no visibility.

Clearly this is creating significant value for bisq, and you supported it via @wiz request. According to you what criteria for compensation is not being fulfilled, and where is this criteria documented?

[chimp1984]

As discussed privately I think/hope we have clearified most of the mis-understandings and different views. Feel free to adjust and make the request again in cycle 8. I will reconsider it again based on the result of our discussions and on the requested amount. In doubt you can split it up to multiple requests as well.

[MwithM]

Closed as rejected & posposed.