Reduce bs formatter interface #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bodymindarts I think because of the merge of the release branch your PR needs to be updated. |
bodymindarts
force-pushed
the
reduce-BSFormatter-interface
branch
from
abb3f18 to
3ca10fd
Compare
|
Rebased vs master. Thanks for the hint @ripcurlx |
@bodymindarts There are still (or again) conflicts with master. |
bodymindarts
force-pushed
the
reduce-BSFormatter-interface
branch
from
3ca10fd to
b8730ad
Compare
|
@bodymindarts Based on our new GitHub configuration all your commits must be signed to be able to merge it. Please update also your old commits. Thanks! |
added 4 commits
November 19, 2019 09:23
All formatting related functions that are depended on by core and desktop jars are extracted to the new class FormattingUtils.
Make them private instance functions at call site to minimize dependencies.
bodymindarts
force-pushed
the
reduce-BSFormatter-interface
branch
from
aa24ddb to
cfaa23e
Compare
|
@ripcurlx re-uploaded with signed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of my ongoing refactoring to remove BSFormatter.
This is the last refactoring that deals with method extraction. Next step will be to extract the CoinFormatter interface to deal with the polymorphism between BsFormatter and BsqFormatter.
Tracking issue: #3240